Support setting IAM on PrivateCACAPool #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
force-pushed
the
privatecacapool_iam_2
branch
from
0de3255
to
4ce16ba
Compare
justinsb
force-pushed
the
privatecacapool_iam_2
branch
2 times, most recently
from
3e4e677
to
0f9e425
Compare
justinsb
force-pushed
the
privatecacapool_iam_2
branch
from
0f9e425
to
728dae6
Compare
justinsb
changed the title
justinsb
force-pushed
the
privatecacapool_iam_2
branch
4 times, most recently
from
3937f94
to
bf626e4
Compare
justinsb
force-pushed
the
privatecacapool_iam_2
branch
4 times, most recently
from
70d852c
to
6e9ca35
Compare
justinsb
changed the title
justinsb
force-pushed
the
privatecacapool_iam_2
branch
from
ed36fe1
to
7f976c1
Compare
This uses our direct actuation framework.
justinsb
force-pushed
the
privatecacapool_iam_2
branch
from
7f976c1
to
257598e
Compare
yuwenma
reviewed
Jun 27, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit ae65499
into
GoogleCloudPlatform:master
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do this in our direct controller, though we only need to implement the (new) IAM-related methods.
These methods are optional (at least for now!)